snuyanzin commented on code in PR #23505:
URL: https://github.com/apache/flink/pull/23505#discussion_r1452769505
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecWindowTableFunction.java:
##########
@@ -77,6 +79,11 @@ protected CommonExecWindowTableFunction(
@Override
protected Transformation<RowData> translateToPlanInternal(
PlannerBase planner, ExecNodeConfig config) {
+ if (windowingStrategy.getWindow() instanceof SessionWindowSpec) {
+ // TODO introduce session window tvf op instead of falling back to
group window
Review Comment:
IMHO todo is not the best way...
current code is full of TODOs, however the main problem with them is that no
one is tracking them...
So probably it's better to create a JIRA issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
