xuyangzhong commented on code in PR #23505:
URL: https://github.com/apache/flink/pull/23505#discussion_r1453268495
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -1432,9 +1433,15 @@ private void substituteSubQuery(Blackboard bb, SubQuery
subQuery) {
bb.cursors.add(converted.r);
return;
case SET_SEMANTICS_TABLE:
- if (!config.isExpand()) {
- return;
- }
+ // ----- FLINK MODIFICATION BEGIN -----
+ // Currently, Flink will not distinguish tvf between SET
semantics and ROW
+ // semantics.
+ // And in Flink, only session window tvf need to support SET
semantics. It will
+ // always be expanded.
+ // if (!config.isExpand()) {
+ // return;
+ // }
Review Comment:
I decide to modify the log in `FlinkConvertletTable` and add a custom rex
call to store the partition keys and order keys for SET SEMANTICS TABLE. I also
put the enough reason on why we always expand the plan the what should we do to
work around it without too hacky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
