xuyangzhong commented on code in PR #23505:
URL: https://github.com/apache/flink/pull/23505#discussion_r1453274839
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.java:
##########
@@ -144,7 +145,8 @@ public RelNode visit(RelNode node) {
|| node instanceof FlinkLogicalSort
|| node instanceof FlinkLogicalOverAggregate
|| node instanceof FlinkLogicalExpand
- || node instanceof FlinkLogicalScriptTransform) {
+ || node instanceof FlinkLogicalScriptTransform
+ || node instanceof FlinkLogicalExchange) {
Review Comment:
In the initial pr, calcite will convert the SET SEMANTICS TABLE with
`partition by` into `LogicalExchange` in the SqlToRel stage, so when do logical
optimization in Flink, unexpected exchange nodes will appear, and then I add
the logic to resolve it.
After I updated my pr, I just modify the plan generated by calcite to be
same as other window table functions. So the logic used to resolve `Exchange`
is removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
