xuyangzhong commented on code in PR #24162:
URL: https://github.com/apache/flink/pull/24162#discussion_r1464774215


##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.xml:
##########
@@ -1186,6 +1186,196 @@ Calc(select=[window_time, start_time, end_time])
          +- Calc(select=[CAST(rowtime AS TIMESTAMP(3)) AS rowtime, rowtime AS 
rowtime_0])
             +- WatermarkAssigner(rowtime=[rowtime], watermark=[-(rowtime, 
1000:INTERVAL SECOND)])
                +- TableSourceScan(table=[[default_catalog, default_database, 
MyTable, project=[rowtime], metadata=[]]], fields=[rowtime])
+]]>
+    </Resource>
+  </TestCase>
+  <TestCase 
name="testGroupKeyLessThanPartitionKeyInSessionWindow[aggPhaseEnforcer=ONE_PHASE]">

Review Comment:
   Good catch! Actually, I have add one test in the pr that this pr is based on 
about planner.
   
![image](https://github.com/apache/flink/assets/25195874/af99e4f7-1970-46bc-b290-11b6fb8b3208)
   
![image](https://github.com/apache/flink/assets/25195874/3c2c9fec-fcef-4a22-b774-529a1ba9d5a8)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to