xuyangzhong commented on code in PR #24162:
URL: https://github.com/apache/flink/pull/24162#discussion_r1466230991
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecWindowTableFunction.java:
##########
@@ -103,4 +111,67 @@ protected Transformation<RowData> translateToPlanInternal(
inputTransform.getParallelism(),
false);
}
+
+ private Transformation<RowData> translateWithUnalignedWindow(
+ PlannerBase planner,
+ ExecNodeConfig config,
+ RowType inputRowType,
+ Transformation<RowData> inputTransform) {
+ final WindowTableFunctionOperatorBase windowTableFunctionOperator =
+ createUnalignedWindowTableFunctionOperator(config,
inputRowType);
+ final OneInputTransformation<RowData, RowData> transform =
+ ExecNodeUtil.createOneInputTransformation(
+ inputTransform,
+ createTransformationMeta(WINDOW_TRANSFORMATION,
config),
+ windowTableFunctionOperator,
+ InternalTypeInfo.of(getOutputType()),
+ inputTransform.getParallelism(),
+ false);
+
+ final int[] partitionKeys =
extractPartitionKeys(windowingStrategy.getWindow());
Review Comment:
If user doesn't specify the partition keys, a EmptyRowDataKeySelector will
be returned.
I'll split this function into StreamXXX and BatchXXX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
