xuyangzhong commented on code in PR #24162:
URL: https://github.com/apache/flink/pull/24162#discussion_r1466235244
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/WindowAggOperatorBuilder.java:
##########
@@ -170,4 +202,17 @@ public SlicingWindowAggOperatorBuilder countStarIndex(int
indexOfCountStart) {
}
return new SlicingWindowOperator<>(windowProcessor);
}
+
+ @SuppressWarnings("unchecked")
+ private WindowOperatorBase<RowData, ?> buildUnslicingWindowOperator() {
+ final UnsliceWindowAggProcessor windowProcessor =
+ new UnsliceWindowAggProcessor(
+ (GeneratedNamespaceAggsHandleFunction<TimeWindow>)
+ generatedAggregateFunction,
+ (UnsliceAssigner<TimeWindow>) assigner,
+ accSerializer,
+ indexOfCountStart,
+ shiftTimeZone);
+ return new UnslicingWindowOperator<>(windowProcessor);
Review Comment:
I think it's unnecessary to bind the UnslicingWindowOperator and session
window too strongly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
