jnh5y commented on code in PR #24155:
URL: https://github.com/apache/flink/pull/24155#discussion_r1470422724


##########
flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd:
##########
@@ -147,11 +149,14 @@
     "COMPILE"
     "COLUMNS"
     "DATABASES"
+    "DISTRIBUTED"
+    "DISTRIBUTION"
     "DRAIN"
     "ENFORCED"
     "ESTIMATED_COST"
     "EXTENDED"
     "FUNCTIONS"
+    "HASH"

Review Comment:
   Ok, I tried removing HASH as a reserved keyword.
   
   I am hitting issues around RANGE being a keyword.  I'm trying to read the 
distributionKind using `SqlIdentifier` and I haven't quite figured out how to 
make that work.
   
   The FLIP didn't have the algorithm as quoted, so that's why I added HASH as 
a reserved keyword.  Are you suggesting that algorithm (if supplied) must be 
quoted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to