jnh5y commented on code in PR #24155:
URL: https://github.com/apache/flink/pull/24155#discussion_r1470425266
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java:
##########
@@ -82,7 +85,29 @@ static CatalogTable of(
List<String> partitionKeys,
Map<String, String> options,
@Nullable Long snapshot) {
- return new DefaultCatalogTable(schema, comment, partitionKeys,
options, snapshot);
+ return new DefaultCatalogTable(
+ schema, comment, partitionKeys, options, snapshot,
Optional.empty());
+ }
+
+ /**
+ * Creates an instance of {@link CatalogTable} with a specific snapshot.
+ *
+ * @param schema unresolved schema
+ * @param comment optional comment
+ * @param distribution distribution of the table
+ * @param partitionKeys list of partition keys or an empty list if not
partitioned
+ * @param options options to configure the connector
+ * @param snapshot table snapshot of the table
+ */
+ static CatalogTable of(
Review Comment:
I planned to do that as follow-on ticket to try and make this PR smaller.
Do you want it this initial PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
