mxm commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1478026324
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/state/AutoScalerStateStore.java:
##########
@@ -69,6 +70,13 @@ void storeParallelismOverrides(Context jobContext,
Map<String, String> paralleli
void removeParallelismOverrides(Context jobContext) throws Exception;
+ void storeConfigOverrides(Context jobContext, Configuration
configOverrides) throws Exception;
Review Comment:
I'm happy to rename but I can't imagine another use right now. Are you
suggesting we might store other state in the Configuration which is not related
to the configuration? I think that goes in the direction Gyula's comment
(https://github.com/apache/flink-kubernetes-operator/pull/762#issuecomment-1926743545).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
