mxm commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1478084592
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizer.java:
##########
@@ -43,6 +53,32 @@ public void realize(
getOverrideString(context, parallelismOverrides));
}
+ @Override
+ public void realizeMemoryOverrides(
+ KubernetesJobAutoScalerContext context, Configuration
configOverrides) {
+
+ if (context.getResource() instanceof FlinkDeployment) {
+ var flinkDeployment = ((FlinkDeployment) context.getResource());
+
+
flinkDeployment.getSpec().getFlinkConfiguration().putAll(configOverrides.toMap());
+
+ var totalMemoryOverride =
MemoryTuningUtils.getTotalMemory(configOverrides, context);
+ if (totalMemoryOverride.compareTo(MemorySize.ZERO) > 0) {
+ Resource tmResource =
flinkDeployment.getSpec().getTaskManager().getResource();
+ // Make sure to support the Kubernetes syntax here, which
supports more formats than
+ // Flink's classes.
+ var currentMemory =
+ new MemorySize(
+
(Quantity.parse(tmResource.getMemory()).getNumericalAmount())
Review Comment:
Should be fixed now via
https://github.com/apache/flink-kubernetes-operator/pull/762/commits/693e913122b197ed7dcc5d8d5b564f64d3b13168.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
