gyfora commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1478467989
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkResourceContext.java:
##########
@@ -65,7 +65,7 @@ public KubernetesJobAutoScalerContext
getJobAutoScalerContext() {
}
private KubernetesJobAutoScalerContext createJobAutoScalerContext() {
- Configuration conf = new Configuration(getObserveConfig());
+ Configuration conf = new
Configuration(getDeployConfig(resource.getSpec()));
Review Comment:
I think using the observe config is the right thing to do for the autoscaler
in general. We are observing a flink job with its metrics and configuration and
making scaling decisions.
The deploy config may contain yet undeployed settings .
I think this change only makes this feature more convenient to implement but
I think the right thing to do would be to instead store the original memory
limit in the autoscaler if that's important for the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
