XComp commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1478245157
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##########
@@ -337,7 +337,7 @@ public void
testCheckpointRescalingNonPartitionedStateCausesException() throws E
restClusterClient.updateJobResourceRequirements(jobID,
builder.build()).join();
- waitForRunningTasks(restClusterClient, jobID, parallelism2);
+ waitForRunningTasks(restClusterClient, jobID, 2 * parallelism2);
Review Comment:
this is out-of-scope for FLINK-34336? Was it accidentally added?
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##########
@@ -427,7 +427,8 @@ public void
testCheckpointRescalingWithKeyedAndNonPartitionedState() throws Exce
restClusterClient.updateJobResourceRequirements(jobID,
builder.build()).join();
- waitForRunningTasks(restClusterClient, jobID, parallelism2);
+ // Source is parallelism, the flatMapper & Sink is parallelism2
+ waitForRunningTasks(restClusterClient, jobID, parallelism +
parallelism2);
Review Comment:
Can't we also reduce the cooldown phase to make the test complete faster
similarly to what you did in
https://github.com/1996fanrui/flink/commit/ffd713e24d37db2c103e4cd4361d0cd916d0d2f6?
I tried it locally but it didn't help, though. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
