1996fanrui commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1479230252
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##########
@@ -427,7 +427,8 @@ public void
testCheckpointRescalingWithKeyedAndNonPartitionedState() throws Exce
restClusterClient.updateJobResourceRequirements(jobID,
builder.build()).join();
- waitForRunningTasks(restClusterClient, jobID, parallelism2);
+ // Source is parallelism, the flatMapper & Sink is parallelism2
+ waitForRunningTasks(restClusterClient, jobID, parallelism +
parallelism2);
Review Comment:
> Can't we also reduce the cooldown phase to make the test complete faster
similarly to what you did in
[1996fanrui@ffd713e](https://github.com/1996fanrui/flink/commit/ffd713e24d37db2c103e4cd4361d0cd916d0d2f6)?
I have already reduced it in this PR :
https://github.com/apache/flink/pull/24246, that's why I didn't do it here.
> I tried it locally but it didn't help, though. 🤔
Sorry, I don't understand. Do you mean the test duration is still long or
test still fails?
- Before reducing the cooldown time, the duration of most of tests more than
30s.
- After reducing the cooldown time, the duration of most of tests less than
10s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
