1996fanrui commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1479228550
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##########
@@ -337,7 +337,7 @@ public void
testCheckpointRescalingNonPartitionedStateCausesException() throws E
restClusterClient.updateJobResourceRequirements(jobID,
builder.build()).join();
- waitForRunningTasks(restClusterClient, jobID, parallelism2);
+ waitForRunningTasks(restClusterClient, jobID, 2 * parallelism2);
Review Comment:
The last line calls the rescale api, IIUC, `waitForRunningTasks` should wait
for all tasks of rescaled job.
The task number after rescaling should be `2 * parallelism2`.
That's why I think it's original bug, and it's out-of-scope for FLINK-34336.
Other tests are similar with here, but other tests wait for all task of
rescaled job.
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##########
@@ -337,7 +337,7 @@ public void
testCheckpointRescalingNonPartitionedStateCausesException() throws E
restClusterClient.updateJobResourceRequirements(jobID,
builder.build()).join();
- waitForRunningTasks(restClusterClient, jobID, parallelism2);
+ waitForRunningTasks(restClusterClient, jobID, 2 * parallelism2);
Review Comment:
The last line calls the rescale api, IIUC, `waitForRunningTasks` should wait
for all tasks of rescaled job.
The task number after rescaling should be `2 * parallelism2`.
That's why I think it's an original bug, and it's out-of-scope for
FLINK-34336.
Other tests are similar with here, but other tests wait for all task of
rescaled job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
