snuyanzin commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1493015749
##########
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##########
@@ -55,7 +58,7 @@ private static URLClassLoader createClassLoader(File root,
ClassLoader parent)
return new URLClassLoader(new URL[] {root.toURI().toURL()}, parent);
}
- private static void writeAndCompile(File root, String filename, String
source)
+ public static void writeAndCompile(File root, String filename, String
source)
Review Comment:
not related to this change however since this class is touched
I think in this line (above)
```java
return withRoot(root).addClass(filename.replaceAll("\\.java", ""),
source).build();
```
we could use just `replace` which doesn't spend resources for regex
compilation like
```java
return withRoot(root).addClass(filename.replace(".java", ""),
source).build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
