snuyanzin commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1493019218
##########
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##########
@@ -158,7 +170,7 @@ public ClassLoaderBuilder withParentClassLoader(ClassLoader
classLoader) {
return this;
}
- public URLClassLoader build() throws IOException {
+ public ClassLoaderBuilder compile() throws IOException {
Review Comment:
should we name it `writeAndCompile`?
Otherwise the naming is IMHO a bit confusing : it is named `compile` and
then besides compilations also makes some writing based on other methods names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
