yuxiqian commented on code in PR #3207: URL: https://github.com/apache/flink-cdc/pull/3207#discussion_r1568134905
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisRowConverter.java: ########## @@ -103,7 +103,8 @@ static SerializationConverter createExternalConverter(DataType type, ZoneId pipe return (index, val) -> val.getTimestamp(index, DataTypeChecks.getPrecision(type)) .toLocalDateTime() - .format(DorisEventSerializer.DATE_TIME_FORMATTER); + .toString() + .replace('T', ' '); Review Comment: What about fixing `DorisEventSerializer.DATE_TIME_FORMATTER` instead of doing string-level operations? It should make code clearer and more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org