yuxiqian commented on code in PR #3207:
URL: https://github.com/apache/flink-cdc/pull/3207#discussion_r1568485784
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/java/org/apache/flink/cdc/connectors/doris/sink/DorisRowConverterTest.java:
##########
@@ -86,7 +113,9 @@ public void testExternalConvert() {
row.add(converter.serialize(i, recordData));
}
Assert.assertEquals(
- "[true, 1.2, 1.2345, 1, 32, 64, 128, 2021-01-01 08:00:00,
2021-01-01, a, doris]",
+ "[true, 1.2, 1.2345, 1, 32, 64, 128, 2021-01-01
08:00:00.000000, 2021-01-01, a, doris, 2021-01-01 "
+ + "08:01:11.000000, 2021-01-01 08:01:11.123000,
2021-01-01 08:01:11.123456, 2021-01-01 "
+ + "16:01:11.000000, 2021-01-01 16:01:11.123000,
2021-01-01 16:01:11.123456]",
Review Comment:
This assertion will fail when running on any machine which doesn't use UTC+8
timezone. Maybe dynamically generating expected data based on local timezone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
