[
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851865#comment-17851865
]
Rui Fan commented on FLINK-35496:
---------------------------------
Thanks [~leonard] for the clarification, I misunderstood it before! It's clear
for now.
I commented it at
[https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
due to I checked the FileSink[1] in flink repo, FileSink is marked as
@Experimental since the first version.
And sorry for merging this Jira quickly. I discussed with [~eskabetxe]
(Contributor of new jdbc sink), [~Sergey Nuyanzin] (Reviewer of new jdbc sink)
and [~RocMarshal] (Contributor of new jdbc source) in Slack. All of them agree
that marking new jdbc sink and source to Experimental. And in order not to
block the jdbc connector 3.2.0 release, I merged it yesterday.
Next time I will merge the PR after hearing more confirmation. Sorry for that
again.
IIUC, based on the current conclusions, we need to do the following steps:
* [~RocMarshal] needs to cancel the -1 vote in the release mail [2]
* We need to revert the b955e8b5479c65512f94ee7270eb2868a4a14ebe (The commit
of current JIRA)
* Also, we need to update the FIx version of current Jira from jdbc-3.2.0 to
jdbc-3.3.0 due to all commits of current Jira won't be released in jdbc-3.2.0
Please correct me if anything is wrong, and we can go ahead after [~leonard] 's
double check, thank you again.:)
BTW, should we update the Experimental to PublicEvolving for FileSink as
well[2]?
[1]
[https://github.com/apache/flink/blob/e4fa72d9e480664656818395741c37a9995f9334/flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/FileSink.java#L132]
[2] [https://lists.apache.org/thread/b7xbjo4crt1527ldksw4nkwo8vs56csy]
> The annotations of the new JDBC connector should be changed to
> non-Public/non-PublicEvolving
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
> Issue Type: Technical Debt
> Components: Connectors / JDBC
> Reporter: RocMarshal
> Assignee: João Boto
> Priority: Major
> Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}
> or {{Public}} for new features or new apis. But {{JdbcSink}} and
> JdbcSource(merged ) was marked as {{PublicEvolving}} in the first version.
> [~fanrui] commented it to the original PR[1].[1]
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
