[ 
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851899#comment-17851899
 ] 

RocMarshal commented on FLINK-35496:
------------------------------------

- I carefully read the discussion and found that our Rules do not strictly 
require the use of Experimental annotations on the connector API. However, 
during the review, it was recommended not to use such annotations on the 
connector API.
- I checked and found that only the generate connector and file connector used 
Experimental annotations in the connectors module of the Flink main repository. 
And it was developed a long time ago.


*So, can we assume that there is ambiguity in the use of annotations for 
connectors?* 

*Should we change the Rules for connectors so that developers and reviewers 
could strictly adhere to this unified rules?*
[~leonard] I'd be appreciated with your confirmation.

> The annotations of the new JDBC connector should be changed to 
> non-Public/non-PublicEvolving
> --------------------------------------------------------------------------------------------
>
>                 Key: FLINK-35496
>                 URL: https://issues.apache.org/jira/browse/FLINK-35496
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Connectors / JDBC
>            Reporter: RocMarshal
>            Assignee: João Boto
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}  
> or {{Public}}  for new features or new apis. But  {{JdbcSink}} and 
> JdbcSource(merged ) was marked as {{PublicEvolving}}  in the first version. 
> [~fanrui]  commented it to the original PR[1].[1] 
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to