[
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851878#comment-17851878
]
Leonard Xu commented on FLINK-35496:
------------------------------------
> I commented it at
> https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589
> due to I checked the FileSink[1] in flink repo, FileSink is marked as
> @Experimental since the first version.
The Experimental annotation for FileSink was added when UnifiedSink was also
annotated as Experimental
https://github.com/apache/flink/pull/13576/files#diff-8ba42ec08c6cd57a4aa2dd4da5660919896fd06c9c421ca1b2b32b2ebb8b60b3
>IIUC, based on the current conclusions, we need to do the following steps:
> RocMarshal needs to cancel the -1 vote in the release mail [2]
> We need to revert the b955e8b5479c65512f94ee7270eb2868a4a14ebe (The commit of
> current JIRA)
>Also, we need to update the FIx version of current Jira from jdbc-3.2.0 to
>jdbc-3.3.0 due to all commits of current Jira won't be released in jdbc-3.2.0
Yes, it makes sense to me.
> BTW, should we update the Experimental to PublicEvolving for FileSink as
> well[2]?
+1 for this as Unified Sink has been changed to PublicEvolving
> The annotations of the new JDBC connector should be changed to
> non-Public/non-PublicEvolving
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
> Issue Type: Technical Debt
> Components: Connectors / JDBC
> Reporter: RocMarshal
> Assignee: João Boto
> Priority: Major
> Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}
> or {{Public}} for new features or new apis. But {{JdbcSink}} and
> JdbcSource(merged ) was marked as {{PublicEvolving}} in the first version.
> [~fanrui] commented it to the original PR[1].[1]
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
