mateczagany commented on code in PR #842:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/842#discussion_r1647489599
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##########
@@ -48,8 +48,8 @@ public void testApplyOverrides() {
.get(PipelineOptions.PARALLELISM_OVERRIDES.key()))
.satisfiesAnyOf(
// Currently no enforced order inside the overrides
string
- overrides ->
assertThat(overrides).isEqualTo("a:1,b:2"),
- overrides ->
assertThat(overrides).isEqualTo("b:2,a:1"));
+ overrides -> assertThat(overrides).isEqualTo("{a: '1',
b: '2'}"),
+ overrides -> assertThat(overrides).isEqualTo("{b: '2',
a: '1'}"));
Review Comment:
Just as a side note, someone on Flink Slack mentioned that they cannot use
the configuration `pipeline.serialization-config` with the operator because
that would require the new YAML parser.
I think it would make sense to add support for the new `config.yaml` file
for Flink resources and possibly for the operator itself in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
