yuxiqian commented on code in PR #3425:
URL: https://github.com/apache/flink-cdc/pull/3425#discussion_r1647487080
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaDerivation.java:
##########
@@ -84,34 +88,50 @@ public List<SchemaChangeEvent>
applySchemaChange(SchemaChangeEvent schemaChangeE
SchemaChangeEvent derivedSchemaChangeEvent =
ChangeEventUtils.recreateSchemaChangeEvent(schemaChangeEvent, derivedTable);
schemaManager.applySchemaChange(derivedSchemaChangeEvent);
- return Collections.singletonList(derivedSchemaChangeEvent);
- }
-
- // Many-to-1 mapping (merging tables)
- Schema derivedTableSchema =
schemaManager.getLatestSchema(derivedTable).get();
- if (schemaChangeEvent instanceof CreateTableEvent) {
- return handleCreateTableEvent(
- (CreateTableEvent) schemaChangeEvent,
derivedTableSchema, derivedTable);
- } else if (schemaChangeEvent instanceof AddColumnEvent) {
- return handleAddColumnEvent(
- (AddColumnEvent) schemaChangeEvent,
derivedTableSchema, derivedTable);
- } else if (schemaChangeEvent instanceof AlterColumnTypeEvent) {
- return handleAlterColumnTypeEvent(
- (AlterColumnTypeEvent) schemaChangeEvent,
derivedTableSchema, derivedTable);
- } else if (schemaChangeEvent instanceof DropColumnEvent) {
- return Collections.emptyList();
- } else if (schemaChangeEvent instanceof RenameColumnEvent) {
- return handleRenameColumnEvent(
- (RenameColumnEvent) schemaChangeEvent,
derivedTableSchema, derivedTable);
+ events.add(derivedSchemaChangeEvent);
Review Comment:
I think "single source" might be more concise since route sink can be 1 or
many.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
