Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2916#discussion_r90408543
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
 ---
    @@ -53,6 +56,9 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
        /** The initial position to start reading Kinesis streams from (LATEST 
is used if not set) */
        public static final String STREAM_INITIAL_POSITION = 
"flink.stream.initpos";
     
    +   /** The initial timestamp to start reading Kinesis stream from (when 
AT_TIMESTAMP is set for STREAM_INITIAL_POSITION */
    +   public static final String STREAM_INITIAL_TIMESTAMP = 
"flink.stream.init.timestamp";
    --- End diff --
    
    What do you think about renaming this to `flink.stream.initpos.timestamp`, 
instead of `flink.stream.init.timestamp`?
    I personally think it's a good idea to do so, because essentially 
`STREAM_INITIAL_TIMESTAMP` is a sub-setting of `STREAM_INITIAL_POSITION`. In 
other words, `STREAM_INITIAL_TIMESTAMP` will be meaningless is a 
`STREAM_INITIAL_POSITION = AT_TIMESTAMP` isn't set in the config.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to