Github user tzulitai commented on a diff in the pull request:
    --- Diff: 
    @@ -145,6 +145,39 @@ public void 
testUnrecognizableStreamInitPositionTypeInConfig() {
    +   public void 
testStreamInitPositionTypeSetToAtTimestampButNoInitTimestampSetInConfig() {
    +           exception.expect(IllegalArgumentException.class);
    +           exception.expectMessage("Please set value for initial timestamp 
    +                   + ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP + 
"') when using AT_TIMESTAMP initial position.");
    +           Properties testConfig = new Properties();
    +           testConfig.setProperty(ConsumerConfigConstants.AWS_REGION, 
    +           KinesisConfigUtil.validateConsumerConfiguration(testConfig);
    +   }
    +   @Test
    +   public void testUnparsableDateForInitialTimestampInConfig() {
    +           exception.expect(IllegalArgumentException.class);
    +           exception.expectMessage("Invalid value given for initial 
timestamp for AT_TIMESTAMP initial position in stream. "
    --- End diff --
    I would suggest to not let the expect message be this verbose in tests.
    This increases the likeliness that the tests will need to be altered, 
whenever we want to tweak the messages a bit.
    I think `Invalid value given for initial timestamp for AT_TIMESTAMP initial 
position in stream` is enough.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to