Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2916#discussion_r90410957
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -57,6 +60,17 @@ public static void
validateConsumerConfiguration(Properties config) {
}
throw new IllegalArgumentException("Invalid
initial position in stream set in config. Valid values are: " + sb.toString());
}
+
+ // specified initial timestamp in stream when using
AT_TIMESTAMP
+ if (InitialPosition.valueOf(initPosType) ==
InitialPosition.AT_TIMESTAMP) {
+ if
(!config.containsKey(ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP)) {
+ throw new
IllegalArgumentException("Please set value for initial timestamp ('"
+ +
ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP + "') when using AT_TIMESTAMP
initial position.");
+ }
+ validateOptionalDateProperty(config,
ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP,
+ "Invalid value given for initial
timestamp for AT_TIMESTAMP initial position in stream. "
+ + "Must be a valid format:
yyyy-MM-dd'T'HH:mm:ss.SSSXXX or non-negative double value. For example,
2016-04-04T19:58:46.480-00:00 or 1459799926.480 .");
--- End diff --
That's really good error messaging for the user :) Like I mentioned above,
we need to inform this in the document as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
