fredia commented on code in PR #25135:
URL: https://github.com/apache/flink/pull/25135#discussion_r1701487658
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##########
@@ -179,9 +181,12 @@ public final <T> ThrowingConsumer<StreamRecord<T>,
Exception> getRecordProcessor
/** Create new state (v2) based on new state descriptor. */
protected <N, S extends State, T> S getOrCreateKeyedState(
- TypeSerializer<N> namespaceSerializer, StateDescriptor<T>
stateDescriptor)
Review Comment:
Should this function override the
`AbstractStreamOperator#getOrCreateKeyedState`? I am worried that developers
may misuse it. When writing asynchronous operators, calling
`getOrCreateKeyedState` without `defaultNamespace` ​​parameter would create a
synchronous state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
