Zakelly commented on code in PR #25135:
URL: https://github.com/apache/flink/pull/25135#discussion_r1706763084
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStValueState.java:
##########
@@ -87,8 +93,10 @@ public byte[] serializeKey(ContextKey<K, N> contextKey)
throws IOException {
ctxKey -> {
SerializedCompositeKeyBuilder<K> builder =
serializedKeyBuilder.get();
builder.setKeyAndKeyGroup(ctxKey.getRawKey(),
ctxKey.getKeyGroup());
+ N namespace = contextKey.getNamespace(this);
Review Comment:
Well we cannot omit `namespace` param and assign a `VoidNamespace.INSTANCE`
if not provided, since the `namespaceSerializer` should know how to serialize
the `VoidNamespace.INSTANCE` if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
