kottmann commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1722888913
########## flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemITCase.java: ########## @@ -48,20 +44,12 @@ * href="https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel";>consistency * guarantees</a> and what the {@link com.facebook.presto.hive.s3.PrestoS3FileSystem} offers. */ -@RunWith(Parameterized.class) -public class PrestoS3FileSystemITCase extends AbstractHadoopFileSystemITTest { - - @Parameterized.Parameter public String scheme; - - @Parameterized.Parameters(name = "Scheme = {0}") - public static List<String> parameters() { - return Arrays.asList("s3", "s3p"); - } +class PrestoS3FileSystemITCase extends AbstractHadoopFileSystemITTest { Review Comment: The parameter "schema" wasn't used in the test before, therefore nothing should change by removing it. Let me compare the number of tests and then comment here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
