Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1724162979
##########
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableWriterCommitterTest.java:
##########
@@ -122,7 +121,7 @@ public void before() {
expectedBytes = new ByteArrayOutputStream();
}
- @After
+ @AfterEach
public void after() throws IOException {
Review Comment:
```suggestion
void after() throws IOException {
```
##########
flink-filesystems/flink-oss-fs-hadoop/src/test/java/org/apache/flink/fs/osshadoop/HadoopOSSRecoverableWriterITCase.java:
##########
@@ -39,13 +39,13 @@
* Tests for the {@link
org.apache.flink.fs.osshadoop.writer.OSSRecoverableWriter
* OSSRecoverableWriter}.
*/
-public class HadoopOSSRecoverableWriterITCase extends
AbstractHadoopRecoverableWriterITCase {
+class HadoopOSSRecoverableWriterITCase extends
AbstractHadoopRecoverableWriterITCase {
// ----------------------- OSS general configuration
-----------------------
private static final int MAX_CONCURRENT_UPLOADS_VALUE = 2;
- @BeforeClass
+ @BeforeAll
public static void checkCredentialsAndSetup() throws IOException {
Review Comment:
Here is missing too.
##########
flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemITCase.java:
##########
@@ -48,20 +44,12 @@
*
href="https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel";>consistency
* guarantees</a> and what the {@link
com.facebook.presto.hive.s3.PrestoS3FileSystem} offers.
*/
-@RunWith(Parameterized.class)
-public class PrestoS3FileSystemITCase extends AbstractHadoopFileSystemITTest {
-
- @Parameterized.Parameter public String scheme;
-
- @Parameterized.Parameters(name = "Scheme = {0}")
- public static List<String> parameters() {
- return Arrays.asList("s3", "s3p");
- }
+class PrestoS3FileSystemITCase extends AbstractHadoopFileSystemITTest {
Review Comment:
Thanks for clarifying. I think it is reasonable to remove it.
##########
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSChecksumWriteChannelTest.java:
##########
@@ -124,7 +126,7 @@ public void before() throws IOException {
*
* @throws IOException On storage failure.
*/
- @Test
+ @TestTemplate
public void shouldWriteProperly() throws IOException {
Review Comment:
Here is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
