ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1725399993
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureBlobRecoverableWriterTest.java:
##########
@@ -46,8 +45,13 @@ class AzureBlobRecoverableWriterTest extends
AbstractRecoverableWriterTest {
@BeforeAll
static void checkCredentialsAndSetup() throws IOException {
// check whether credentials and container details exist
- assumeThat(StringUtils.isNullOrWhitespaceOnly(CONTAINER)).isFalse();
- assumeThat(StringUtils.isNullOrWhitespaceOnly(ACCESS_KEY)).isFalse();
+ Assumptions.assumeFalse(
+ StringUtils.isNullOrWhitespaceOnly(CONTAINER),
+ "Azure container not configured, skipping test...");
+ Assumptions.assumeFalse(
+ StringUtils.isNullOrWhitespaceOnly(ACCESS_KEY),
+ "Azure access key not configured, skipping test...");
Review Comment:
I think we should revert this part to AssertJ's `aasumeThat`.
##########
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriterTest.java:
##########
@@ -49,12 +48,14 @@ class HadoopRecoverableWriterTest extends
AbstractRecoverableWriterTest {
@BeforeAll
static void testHadoopVersion() {
- assumeThat(HadoopUtils.isMinHadoopVersion(2, 6)).isTrue();
+ Assumptions.assumeTrue(HadoopUtils.isMinHadoopVersion(2, 7));
Review Comment:
Although, I think we should keep using AssertJ's `assumeThat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
