reswqa commented on code in PR #25324: URL: https://github.com/apache/flink/pull/25324#discussion_r1764363643
########## flink-tests/src/test/scala/org/apache/flink/api/scala/functions/ClosureCleanerITCase.scala: ########## @@ -1,262 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.flink.api.scala.functions - -import org.apache.flink.api.common.InvalidProgramException -import org.apache.flink.api.scala._ -import org.apache.flink.api.scala.ExecutionEnvironment -import org.apache.flink.core.fs.FileSystem.WriteMode -import org.apache.flink.test.util.{MultipleProgramsTestBaseJUnit4, TestBaseUtils} - -import MultipleProgramsTestBaseJUnit4.TestExecutionMode -import org.junit.{After, Before, Rule, Test} -import org.junit.Assert.fail -import org.junit.rules.TemporaryFolder -import org.junit.runner.RunWith -import org.junit.runners.Parameterized - -/* The test cases are originally from the Apache Spark project. Like the ClosureCleaner itself. */ - -@RunWith(classOf[Parameterized]) -class ClosureCleanerITCase(mode: TestExecutionMode) extends MultipleProgramsTestBaseJUnit4(mode) { Review Comment: Can not remove this. ########## flink-dist-scala/pom.xml: ########## @@ -127,4 +127,4 @@ under the License. </plugin> </plugins> </build> -</project> \ No newline at end of file +</project> Review Comment: ? ########## flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations: ########## @@ -0,0 +1,86 @@ +0,int Review Comment: Why we need this file? ########## flink-tests/src/test/scala/org/apache/flink/api/scala/migration/StatefulJobSavepointMigrationITCase.scala: ########## @@ -1,380 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.flink.api.scala.migration - -import org.apache.flink.FlinkVersion -import org.apache.flink.api.common.accumulators.IntCounter -import org.apache.flink.api.common.functions.{OpenContext, RichFlatMapFunction} -import org.apache.flink.api.common.state.{ListState, ListStateDescriptor, ValueState, ValueStateDescriptor} -import org.apache.flink.api.java.functions.KeySelector -import org.apache.flink.api.java.tuple.Tuple2 -import org.apache.flink.api.scala._ -import org.apache.flink.api.scala.migration.CustomEnum.CustomEnum -import org.apache.flink.configuration.Configuration -import org.apache.flink.contrib.streaming.state.EmbeddedRocksDBStateBackend -import org.apache.flink.runtime.state.{FunctionInitializationContext, FunctionSnapshotContext, StateBackendLoader} -import org.apache.flink.runtime.state.hashmap.HashMapStateBackend -import org.apache.flink.runtime.state.memory.MemoryStateBackend -import org.apache.flink.streaming.api.TimeCharacteristic -import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction -import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment -import org.apache.flink.streaming.api.functions.sink.RichSinkFunction -import org.apache.flink.streaming.api.functions.source.SourceFunction -import org.apache.flink.streaming.api.watermark.Watermark -import org.apache.flink.test.checkpointing.utils.SnapshotMigrationTestBase -import org.apache.flink.test.checkpointing.utils.SnapshotMigrationTestBase.{ExecutionMode, SnapshotSpec, SnapshotType} -import org.apache.flink.test.util.MigrationTest -import org.apache.flink.test.util.MigrationTest.ParameterizedSnapshotsGenerator -import org.apache.flink.util.Collector - -import org.junit.Test -import org.junit.runner.RunWith -import org.junit.runners.Parameterized - -import javax.annotation.Nullable - -import java.util -import java.util.function.BiFunction -import java.util.stream.Collectors - -import scala.util.{Failure, Try} - -object StatefulJobSavepointMigrationITCase { Review Comment: Can not remove tests from `migration` dir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
