codenohup commented on code in PR #25324:
URL: https://github.com/apache/flink/pull/25324#discussion_r1764434807
##########
flink-connectors/flink-hadoop-compatibility/pom.xml:
##########
@@ -28,7 +28,7 @@ under the License.
<version>2.0-SNAPSHOT</version>
</parent>
-
<artifactId>flink-hadoop-compatibility_${scala.binary.version}</artifactId>
+ <artifactId>flink-hadoop-compatibility</artifactId>
Review Comment:
The `flink-hadoop-compatibility` module has no Scala dependency, so rename
the module to remove the Scala version suffix.
##########
flink-connectors/flink-hadoop-compatibility/pom.xml:
##########
@@ -129,40 +122,6 @@ under the License.
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <configuration>
Review Comment:
Remove the Scala-related plugin in the `flink-hadoop-compatibility` maven
pom.xml.
##########
flink-connectors/flink-hadoop-compatibility/src/test/scala/org/apache/flink/api/hadoopcompatibility/scala/WordCountMapreduceITCase.scala:
##########
@@ -1,91 +0,0 @@
-/*
Review Comment:
The WordCountMapreduceITCase has a corresponding Java version, so delete it
directly.
##########
flink-connectors/flink-hadoop-compatibility/src/test/scala/org/apache/flink/api/hadoopcompatibility/scala/WordCountMapredITCase.scala:
##########
@@ -1,89 +0,0 @@
-/*
Review Comment:
The `WordCountMapredITCase` has a corresponding Java version, so delete it
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
