codenohup commented on code in PR #25324:
URL: https://github.com/apache/flink/pull/25324#discussion_r1764473678
##########
flink-dist/src/main/assemblies/opt.xml:
##########
@@ -29,13 +29,6 @@
<baseDirectory>flink-${project.version}</baseDirectory>
Review Comment:
Retain the `flink-dist-scala` module, as the `flink-table` module depends on
several libraries, including scala-library and scala-lang. These libraries are
packaged by the flink-dist-scala module.
##########
flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations:
##########
@@ -0,0 +1,86 @@
+0,int
Review Comment:
This file is copied from
"flink-scala/src/test/resources/flink_11-kryo_registrations" and is used in the
test case
`org.apache.flink.formats.avro.AvroKryoSerializerRegistrationsTest#testDefaultKryoRegisteredClassesDidNotChange`.
After removing the `flink-scala` dependency from the `flink-avro` module,
the test case will throw a null pointer exception if this file is not copied to
the `flink-avro` module.
##########
flink-tests/src/test/java/org/apache/flink/test/completeness/TypeSerializerTestCoverageTest.java:
##########
@@ -160,13 +154,6 @@ public void testTypeSerializerTestCoverage() {
org.apache.flink.queryablestate.client.VoidNamespaceSerializer.class
.getName(),
org.apache.flink.runtime.state.VoidNamespaceSerializer.class.getName(),
- EnumValueSerializer.class.getName(),
Review Comment:
All the removed serializers are located in the `flink-scala` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
