snuyanzin commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827410038
##########
.github/workflows/weekly.yml:
##########
@@ -30,23 +30,20 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
+ }, {
+ flink: 1.20.0,
+ jdk: '8, 11, 17, 21',
Review Comment:
```suggestion
```
since flink now is 19+ we could remove it from here
and put below
```
jdk_version: ${{ matrix.flink_branches.jdk || '8, 11, 17, 21' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
