vahmed-hamdy commented on code in PR #110:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827466774


##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
   compile_and_test:
     strategy:
       matrix:
-        flink: [ 1.18-SNAPSHOT ]
-        jdk: [ '8, 11, 17' ]
+        flink: [ 1.19-SNAPSHOT ]
+        jdk: [ '8, 11, 17, 21' ]
         include:
-          - flink: 1.19-SNAPSHOT
-            jdk: '8, 11, 17, 21'
           - flink: 1.20-SNAPSHOT
             jdk: '8, 11, 17, 21'

Review Comment:
   @snuyanzin Since we are here, is there a reason we are running PR CI tests 
against snapshot versions, should we replace them with `1.19.1` and `1.20.0` ?
   after all we want to test new changes to connector against supporting 
versions, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to