snuyanzin commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827456687
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
Last bit from my side
I think similar story
since now java is same for all it could be replaced with
```
flink: [ 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
jdk: [ '8, 11, 17, 21' ]
```
and we could completely remove everything under `include:` and `include:`
itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
