davidradl commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1871244045
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java:
##########
@@ -566,6 +592,11 @@ public long getSliceEndInterval() {
return innerAssigner.getSliceEndInterval();
}
+ @Override
+ public long getWindowOffset() {
+ return 0;
Review Comment:
I am curious, if the children do not override this why is the value 0, where
everywhere else in the code this getter returns offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
