xing1mo commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1873328699


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java:
##########
@@ -194,10 +198,12 @@ public static long getNextTriggerWatermark(
         if (useDayLightSaving) {
             long utcWindowStart =
                     getWindowStartWithOffset(
-                            toUtcTimestampMills(currentWatermark, 
shiftTimezone), 0L, interval);

Review Comment:
   > timestamp_ltz
   
   Sorry for the ambiguity in my expression. SliceAssigner will save the 
timezone, and the watermark will be consistent with the timezone. For example, 
when using timestamp_ltz, the watermark is UTC time. These time conversions are 
handled in sliceAssigner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to