davidradl commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1871587710
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java:
##########
@@ -194,10 +198,12 @@ public static long getNextTriggerWatermark(
if (useDayLightSaving) {
long utcWindowStart =
getWindowStartWithOffset(
- toUtcTimestampMills(currentWatermark,
shiftTimezone), 0L, interval);
Review Comment:
Is watermark time always local? Does it not depend on whether the watermark
field type is Timestamp or timestamp_ltz ?
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/timezone/#timestamp-vs-timestamp_ltz
I assume timestamp_ltz would/could have daylight savings, but TIMESTAMP is
time from epoch. For time from epoch we should not be adding daylight savings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
