SinBex commented on code in PR #25822:
URL: https://github.com/apache/flink/pull/25822#discussion_r1904872750
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java:
##########
@@ -161,21 +216,23 @@ private boolean
validateStreamEdgeUpdateRequest(StreamEdgeUpdateRequestInfo requ
}
// Modification is not allowed when the subscribing output is reused.
- Map<StreamEdge, NonChainedOutput> opIntermediateOutputs =
- opIntermediateOutputsCaches.get(sourceNodeId);
- NonChainedOutput output =
- opIntermediateOutputs != null ?
opIntermediateOutputs.get(targetEdge) : null;
- if (output != null) {
- Set<StreamEdge> consumerStreamEdges =
- opIntermediateOutputs.entrySet().stream()
- .filter(entry -> entry.getValue().equals(output))
- .map(Map.Entry::getKey)
- .collect(Collectors.toSet());
- if (consumerStreamEdges.size() != 1) {
- LOG.info(
- "Skip modifying edge {} because the subscribing output
is reused.",
- targetEdge);
- return false;
+ if (requestInfo.getOutputPartitioner() != null) {
Review Comment:
Maybe we only need to check if the subscribing output is reused when
modifying the partitioner. Other actions, like changing the type number, are
not subject to this restriction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
