SinBex commented on code in PR #25822:
URL: https://github.com/apache/flink/pull/25822#discussion_r1904873010
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/adaptive/AdaptiveJoinOperatorGenerator.java:
##########
@@ -155,4 +155,15 @@ public void markAsBroadcastJoin(boolean canBroadcast,
boolean leftIsBuild) {
this.isBroadcastJoin = canBroadcast;
this.leftIsBuild = leftIsBuild;
}
+
+ @Override
+ public boolean shouldReorderInputs() {
+ // Sort merge join requires the left side to be read first if the
broadcast threshold is not
+ // met.
+ if (!isBroadcastJoin && originalJoin == OperatorType.SortMergeJoin) {
Review Comment:
yes，you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
