fsk119 commented on code in PR #25754:
URL: https://github.com/apache/flink/pull/25754#discussion_r1904880987
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java:
##########
@@ -125,21 +137,37 @@ void executeInInteractiveMode(LineReader lineReader) {
}
/** Opens the non-interactive CLI shell. */
- public void executeInNonInteractiveMode(String content) {
+ public void executeInNonInteractiveMode(URI uri) {
try {
terminal = terminalFactory.get();
- executeFile(content, terminal.output(),
ExecutionMode.NON_INTERACTIVE_EXECUTION);
+ if (isApplicationMode(executor.getSessionConfig())) {
+ String scheme = StringUtils.lowerCase(uri.getScheme());
+ String clusterId;
+ // local files
+ if (scheme == null || scheme.equals("file")) {
Review Comment:
Here we just read the sql script file if the file is in local fs. It's not
an easy work to ship files in the k8s deployment. It requires users to
configure a remote oss env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
