hackergin commented on code in PR #25754:
URL: https://github.com/apache/flink/pull/25754#discussion_r1885021737
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliStrings.java:
##########
@@ -213,6 +213,8 @@ public AttributedString build() {
public static final String MESSAGE_EXECUTE_STATEMENT = "Execute statement
succeeded.";
+ public static final String MESSAGE_DEPLOY_SCRIPT = "Deploy script in
cluster: ";
Review Comment:
The log message ‘Deploy script in cluster’ could be improved. It would be
helpful to explicitly indicate that this is submitting in Application mode and
include the corresponding clusterId as xx to enhance readability and
informativeness.
##########
flink-table/flink-sql-jdbc-driver/src/test/java/org/apache/flink/table/jdbc/FlinkStatementTest.java:
##########
@@ -251,6 +254,11 @@ public List<String> completeStatement(String statement,
int position) {
throw new UnsupportedOperationException();
}
+ @Override
+ public String deployScript(@Nullable String script, @Nullable
@Nullable URI path) {
Review Comment:
The @Nullable annotation here seems to be duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
