fsk119 commented on code in PR #25754:
URL: https://github.com/apache/flink/pull/25754#discussion_r1904974155
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliOptions.java:
##########
@@ -35,16 +36,16 @@ public class CliOptions {
private final boolean isPrintHelp;
private final String sessionId;
- private final URL initFile;
- private final URL sqlFile;
+ private final URI initFile;
Review Comment:
Because URL requires to qualify referred resources. For example, if users
uses the hdfs://path/to/object as the input, the sql client needs to validate
whether the protocol is valid. However, in the client side, users may not
configure hdfs parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
