hanyuzheng7 commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1906337467
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -588,34 +588,50 @@ private Stream<TestSetSpec> ceilTestCases() {
LocalDateTime.of(3001, 1, 1, 0, 0),
TIMESTAMP().nullable())
.testResult(
- $("f3").cast(TIMESTAMP_LTZ(3))
+ $("f3").cast(TIMESTAMP_LTZ(4))
.ceil(TimeIntervalUnit.HOUR)
.cast(STRING()),
- "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(3)) TO
HOUR) AS STRING)",
+ "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(4)) TO
HOUR) AS STRING)",
LocalDateTime.of(2021, 9, 24, 10, 0, 0, 0)
.format(TIMESTAMP_FORMATTER),
STRING().nullable())
.testResult(
- $("f3").cast(TIMESTAMP_LTZ(3))
+ $("f3").cast(TIMESTAMP_LTZ(4))
.ceil(TimeIntervalUnit.MINUTE)
.cast(STRING()),
- "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(3)) TO
MINUTE) AS STRING)",
+ "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(4)) TO
MINUTE) AS STRING)",
LocalDateTime.of(2021, 9, 24, 9, 21, 0, 0)
.format(TIMESTAMP_FORMATTER),
STRING().nullable())
.testResult(
- $("f3").cast(TIMESTAMP_LTZ(3))
+ $("f3").cast(TIMESTAMP_LTZ(4))
.ceil(TimeIntervalUnit.SECOND)
.cast(STRING()),
- "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(3)) TO
SECOND) AS STRING)",
+ "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(4)) TO
SECOND) AS STRING)",
LocalDateTime.of(2021, 9, 24, 9, 20, 51, 0)
.format(TIMESTAMP_FORMATTER),
STRING().nullable())
.testResult(
- $("f3").cast(TIMESTAMP_LTZ(3))
+ $("f3").cast(TIMESTAMP_LTZ(4))
.ceil(TimeIntervalUnit.MILLISECOND)
.cast(STRING()),
- "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(3)) TO
MILLISECOND) AS STRING)",
+ "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(4)) TO
MILLISECOND) AS STRING)",
+ LocalDateTime.of(2021, 9, 24, 9, 20, 50,
925_000_000)
+ .format(TIMESTAMP_FORMATTER),
+ STRING().nullable())
+ .testResult(
+ $("f3").cast(TIMESTAMP_LTZ(4))
+ .ceil(TimeIntervalUnit.MICROSECOND)
+ .cast(STRING()),
+ "CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(4)) TO
MICROSECOND) AS STRING)",
+ LocalDateTime.of(2021, 9, 24, 9, 20, 50,
924_000_000)
+ .format(TIMESTAMP_FORMATTER),
Review Comment:
The reason is for [`timestampCeil`
](https://github.com/apache/flink/blob/75c26e8c9fd39b957fd1e79323b4fae97b2ce4a6/flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java#L1252)
the precision is millis, even I deliver nanosecond to this method. So whatever
`TIMESTAMP_FORMATTER` like `DateTimeFormatter.ofPattern("yyyy-MM-dd'
'HH:mm:ss.SSSSSSSSS");` or `DateTimeFormatter.ofPattern("yyyy-MM-dd'
'HH:mm:ss.SSSS");` The result is same `LocalDateTime.of(2021, 9, 24, 9, 20,
50, 924_000_000)`.
The only way to change for this is that we use Nanosecond as time base. But
it seems that we need change this method totally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
