hanyuzheng7 commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1909233445
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FloorCeilCallGen.scala:
##########
@@ -65,15 +65,17 @@ class FloorCeilCallGen(
unit match {
// for Timestamp with timezone info
case MILLENNIUM | CENTURY | DECADE | YEAR | QUARTER | MONTH | WEEK
| DAY | HOUR |
- MINUTE | SECOND | MILLISECOND
- if terms.length + 1 == method.getParameterCount &&
- method.getParameterTypes()(terms.length) ==
classOf[TimeZone] =>
+ MINUTE | SECOND | MILLISECOND | MICROSECOND | NANOSECOND
+ if terms.length + 2 == method.getParameterCount &&
Review Comment:
Thanks, @davidradl, I also feel the code here is not very grace, do you have
some ideas to make it more decent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
