hanyuzheng7 commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1909260699
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -629,8 +645,9 @@ private Stream<TestSetSpec> floorTestCases() {
// Fractional seconds are lost
LocalTime.of(11, 22, 33),
LocalDate.of(1990, 10, 14),
- LocalDateTime.of(2020, 2, 29, 1, 56, 59,
987654321))
- .andDataTypes(TIME(), DATE(), TIMESTAMP())
+ LocalDateTime.of(2020, 2, 29, 1, 56, 59,
987654321),
Review Comment:
Because the test such as
https://github.com/apache/flink/pull/25897/files#diff-7588925e682b7f5b4b2e41fdc4992ef0d9f246ce00696f783c36f993b8aeb7aeR786
still use f2, the reason I use f3 for TIMESTAMP_TLZ is that This time the
precision increase, we should set f3 precision to 9
[here](https://github.com/apache/flink/pull/25897/files#diff-7588925e682b7f5b4b2e41fdc4992ef0d9f246ce00696f783c36f993b8aeb7aeR650),
So if all TIMESTAMP_TLZ tests use f3, I don't need change the tests which
use f2 before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
