fredia commented on code in PR #25884:
URL: https://github.com/apache/flink/pull/25884#discussion_r1909974038
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/FileBasedCache.java:
##########
@@ -97,6 +129,13 @@ public void delete(Path path) {
@Override
FileCacheEntry internalGet(String key, FileCacheEntry value) {
+ if (metricGroup != null) {
Review Comment:
`Key` is reserved for future use.
`internalGet` is used for some customized operations like statistics.
This PR only focuses on the `hit`, `miss` metric which is not related with
`key`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
