fredia commented on code in PR #25884:
URL: https://github.com/apache/flink/pull/25884#discussion_r1912767509


##########
docs/content/docs/ops/metrics.md:
##########
@@ -1526,6 +1526,41 @@ Note that for failed checkpoints, metrics are updated on 
a best efforts basis an
 ### RocksDB
 Certain RocksDB native metrics are available but disabled by default, you can 
find full documentation [here]({{< ref "docs/deployment/config" 
>}}#rocksdb-native-metrics)
 
+### ForStDB
+<table class="table table-bordered">
+  <thead>
+    <tr>
+      <th class="text-left" style="width: 18%">Scope</th>
+      <th class="text-left" style="width: 26%">Metrics</th>
+      <th class="text-left" style="width: 48%">Description</th>
+      <th class="text-left" style="width: 8%">Type</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <th rowspan="4"><strong>Task/Operator</strong></th>
+      <td>forst.fileCache.hit</td>
+      <td>The hit count of ForSt state backend cache.</td>

Review Comment:
    > I am not sure how the invalidation occurs - can you count the number of 
invalidations in a similar way to the hits and misses.
   
   I think "invalidations" == "misses" for a cache. Take a fixed-sized  FIFO 
cache as example, when the requested data is not found in the cache, a "miss(or 
invalidations )" happens. Due to limited size of the cache, if the cache is 
full and new data needs to be added, the oldest data (first-in) will be 
replaced. If this removed data is needed again later, it results in a miss. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to